Skip to content

Conversation

@nvmkuruc
Copy link
Collaborator

Description of Change(s)

if (destSpec = _composedPropertyLayer->GetObjectAtPath(

The previous line produces a warning on GCC13.

warning: suggest parentheses around assignment used as truth value [-Wparentheses]
  408 |         if (destSpec = (_composedPropertyLayer->GetObjectAtPath(
      |             ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  409 |                 primPath.AppendProperty(propName)))) {
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

In #3334, @dgovil suggests this occurs on clang 16 too. Putting parentheses around the expression confirms that the assignment as truth value is intentional.

Link to proposal (if applicable)

Fixes Issue(s)

#3334

Checklist

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-11584

(This is an automated message. See here for more information.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants